Use git to download and install chruby #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use git to download the chruby repo (from any (forked) repo) and install.
Downside to this is that we can't verify the download anymore, but that wasn't be done anyway.
Another approach would be to use remote_file. That way we can drop the dependency for ark as well. We'd have to link to the direct
https://codeload.github.com/postmodern/chruby/tar.gz/v#{node['chruby']['version']}download and install like the nginx cookbook does for example.See downloading here, extracting here and installing here.
Downside to this is not being able to select specific non-released version of chruby, although I doubt one should really be able to install them, they are not released for a reason.
Let me know what approach we should take.
More permanent fix for #19